feat: Integrate ChildSelector in sleep tracking form
Some checks failed
CI/CD Pipeline / Lint and Test (push) Has been cancelled
CI/CD Pipeline / E2E Tests (push) Has been cancelled
CI/CD Pipeline / Build Application (push) Has been cancelled

- Replace local child state with Redux state management
- Use ChildSelector component instead of custom select
- Sync selectedChildIds with Redux store
- Update API calls to use selectedChild.id
- Remove duplicate child loading logic
- Build and test successfully
This commit is contained in:
2025-10-04 21:55:28 +00:00
parent 65ce8bda6c
commit 89a0d7eca7
2 changed files with 47 additions and 54 deletions

View File

@@ -47,6 +47,10 @@ import { childrenApi, Child } from '@/lib/api/children';
import { motion } from 'framer-motion';
import { useLocalizedDate } from '@/hooks/useLocalizedDate';
import { useTranslation } from '@/hooks/useTranslation';
import { useDispatch, useSelector } from 'react-redux';
import { fetchChildren, selectChild, selectSelectedChild, childrenSelectors } from '@/store/slices/childrenSlice';
import { AppDispatch, RootState } from '@/store/store';
import ChildSelector from '@/components/common/ChildSelector';
interface SleepData {
startTime: string;
@@ -61,8 +65,15 @@ export default function SleepTrackPage() {
const { user } = useAuth();
const { t } = useTranslation('tracking');
const { formatDistanceToNow, format } = useLocalizedDate();
const [children, setChildren] = useState<Child[]>([]);
const [selectedChild, setSelectedChild] = useState<string>('');
const dispatch = useDispatch<AppDispatch>();
// Redux state
const children = useSelector((state: RootState) => childrenSelectors.selectAll(state));
const selectedChild = useSelector(selectSelectedChild);
const familyId = useSelector((state: RootState) => state.auth.user?.familyId);
// Local state
const [selectedChildIds, setSelectedChildIds] = useState<string[]>([]);
// Sleep state
const [startTime, setStartTime] = useState<string>(
@@ -79,7 +90,6 @@ export default function SleepTrackPage() {
const [notes, setNotes] = useState<string>('');
const [recentSleeps, setRecentSleeps] = useState<Activity[]>([]);
const [loading, setLoading] = useState(false);
const [childrenLoading, setChildrenLoading] = useState(true);
const [sleepsLoading, setSleepsLoading] = useState(false);
const [error, setError] = useState<string | null>(null);
const [successMessage, setSuccessMessage] = useState<string | null>(null);
@@ -88,46 +98,33 @@ export default function SleepTrackPage() {
const [deleteDialogOpen, setDeleteDialogOpen] = useState(false);
const [activityToDelete, setActivityToDelete] = useState<string | null>(null);
const familyId = user?.families?.[0]?.familyId;
// Load children
// Load children from Redux
useEffect(() => {
if (familyId) {
loadChildren();
if (familyId && children.length === 0) {
dispatch(fetchChildren(familyId));
}
}, [familyId]);
}, [familyId, dispatch, children.length]);
// Load recent sleeps when child is selected
// Sync selectedChildIds with Redux selectedChild
useEffect(() => {
if (selectedChild) {
loadRecentSleeps();
if (selectedChild?.id) {
setSelectedChildIds([selectedChild.id]);
}
}, [selectedChild]);
const loadChildren = async () => {
if (!familyId) return;
try {
setChildrenLoading(true);
const childrenData = await childrenApi.getChildren(familyId);
setChildren(childrenData);
if (childrenData.length > 0) {
setSelectedChild(childrenData[0].id);
}
} catch (err: any) {
console.error('Failed to load children:', err);
setError(err.response?.data?.message || 'Failed to load children');
} finally {
setChildrenLoading(false);
// Load recent sleeps when child is selected
useEffect(() => {
if (selectedChild?.id) {
loadRecentSleeps();
}
};
}, [selectedChild?.id]);
const loadRecentSleeps = async () => {
if (!selectedChild) return;
if (!selectedChild?.id) return;
try {
setSleepsLoading(true);
const activities = await trackingApi.getActivities(selectedChild, 'sleep');
const activities = await trackingApi.getActivities(selectedChild.id, 'sleep');
// Sort by timestamp descending and take last 10
const sorted = activities.sort((a, b) =>
new Date(b.timestamp).getTime() - new Date(a.timestamp).getTime()
@@ -183,7 +180,7 @@ export default function SleepTrackPage() {
};
const handleSubmit = async () => {
if (!selectedChild) {
if (!selectedChild?.id) {
setError('Please select a child');
return;
}
@@ -223,7 +220,7 @@ export default function SleepTrackPage() {
data.endTime = endTime;
}
await trackingApi.createActivity(selectedChild, {
await trackingApi.createActivity(selectedChild.id, {
type: 'sleep',
timestamp: startTime,
data,
@@ -320,7 +317,9 @@ export default function SleepTrackPage() {
return `${duration} - ${data.location.charAt(0).toUpperCase() + data.location.slice(1)}`;
};
if (childrenLoading) {
const childrenLoading = useSelector((state: RootState) => state.children.loading);
if (childrenLoading && children.length === 0) {
return (
<ProtectedRoute>
<AppShell>
@@ -393,27 +392,21 @@ export default function SleepTrackPage() {
transition={{ duration: 0.3 }}
>
{/* Child Selector */}
{children.length > 1 && (
{children.length > 0 && (
<Paper sx={{ p: 2, mb: 3 }}>
<FormControl fullWidth>
<InputLabel id="sleep-child-select-label">{t('common.selectChild')}</InputLabel>
<Select
labelId="sleep-child-select-label"
value={selectedChild}
onChange={(e) => setSelectedChild(e.target.value)}
label={t('common.selectChild')}
required
inputProps={{
'aria-required': 'true',
}}
>
{children.map((child) => (
<MenuItem key={child.id} value={child.id}>
{child.name}
</MenuItem>
))}
</Select>
</FormControl>
<ChildSelector
children={children}
selectedChildIds={selectedChildIds}
onChange={(childIds) => {
setSelectedChildIds(childIds);
if (childIds.length > 0) {
dispatch(selectChild(childIds[0]));
}
}}
mode="single"
label={t('common.selectChild')}
required
/>
</Paper>
)}

File diff suppressed because one or more lines are too long